[Intl] Blacklist Eurozone and United Nations in Region Data Generator #28396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gregurco
commented
Sep 7, 2018
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28260 |
| License | MIT |
| Doc PR | - |
nicolas-grekas
approved these changes
Sep 8, 2018
| @@ -34,6 +34,8 @@ class RegionDataGenerator extends AbstractDataGenerator | |||
| const BOUVET_ISLAND_ID = 'BV'; | |||
| const HEARD_MCDONALD_ISLANDS_ID = 'HM'; | |||
| const CLIPPERTON_ISLAND_ID = 'CP'; | |||
| const EUROZONE_UNION_ID = 'EZ'; | |||
There was a problem hiding this comment.
actually, this should be named EUROZONE_ID I suppose
There was a problem hiding this comment.
fixed. I found in wiki that EZ is a monetary union, that's why I added union in constant name 🙂 but yep, finally it's not a usual "union".
|
Actually, the data also had to be updated. I just did it by pushing to your fork. |
javiereguiluz
approved these changes
Sep 10, 2018
stof
approved these changes
Sep 10, 2018
|
Thank you @gregurco. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 10, 2018
…a Generator (gregurco) This PR was merged into the 2.8 branch. Discussion ---------- [Intl] Blacklist Eurozone and United Nations in Region Data Generator | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28260 | License | MIT | Doc PR | - Commits ------- e2e4049 [Intl] Blacklist Eurozone and United Nations in Region Data Generator
This was referenced Sep 30, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.