[Console] Fix SymfonyQuestionHelper::askQuestion() with choice value as default #28401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gemorroj
added a commit
to Gemorroj/console-phar-example
that referenced
this pull request
Sep 8, 2018
nicolas-grekas
approved these changes
Sep 8, 2018
chalasr
pushed a commit
that referenced
this pull request
Sep 8, 2018
…oice value as default (chalasr) This PR was merged into the 2.8 branch. Discussion ---------- [Console] Fix SymfonyQuestionHelper::askQuestion() with choice value as default | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26885 | License | MIT | Doc PR | n/a There is an inconsistency between `SymfonyStyle::askQuestion(new ChoiceQuestion(...))` and `SymfonyStyle::choice(...)`, the former does not support to have a choice value as default instead of a choice key while the latter handles both. This is causing an `undefined index` notice breaking interactive command testing, fixed here. Commits ------- c51dda0 [Console] Fix SymfonyQuestionHelper::askQuestion() with choice value as default
This was referenced Sep 30, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an inconsistency between
SymfonyStyle::askQuestion(new ChoiceQuestion(...))andSymfonyStyle::choice(...), the former does not support to have a choice value as default instead of a choice key while the latter handles both.This is causing an
undefined indexnotice breaking interactive command testing, fixed here.