[Debug] fix detecting overriden final/internal methods implemented using traits #28411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Sep 9, 2018
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 9, 2018
…lemented using traits (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [Debug] fix detecting overriden final/internal methods implemented using traits | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- d638237 [Debug] fix detecting overriden final/internal methods implemented using traits
nicolas-grekas
added a commit
that referenced
this pull request
Sep 22, 2018
…" method is considered internal" (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [Debug] Fix false-positive "MicroKernelTrait::loadRoutes()" method is considered internal" | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes (fixing and unreleased issue) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28549 | License | MIT | Doc PR | - Introduced in #28411 Just a failing test for now. Commits ------- 46c4f71 [Debug] Fix false-positive "MicroKernelTrait::loadRoutes()" method is considered internal"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.