[PhpUnitBridge] enable DebugClassLoader by default #28412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Sep 9, 2018
| @@ -984,8 +984,6 @@ public function setCache(array $options) | |||
| * @return $this | |||
| * | |||
| * @see http://tools.ietf.org/html/rfc2616#section-10.3.5 | |||
| * | |||
| * @final | |||
There was a problem hiding this comment.
This method is extended in StreamedResponse, so it cannot be final.
There was a problem hiding this comment.
Removed in favor of #28483
nicolas-grekas
commented
Sep 9, 2018
| @@ -52,6 +53,8 @@ public function __construct(array $mockedNamespaces = array()) | |||
| Blacklist::$blacklistedClassNames['\Symfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerTrait'] = 2; | |||
| } | |||
|
|
|||
| $enableDebugClassLoader = \class_exists('Symfony\Component\Debug\DebugClassLoader'); | |||
There was a problem hiding this comment.
(as a reminder, because we want to use it when testing branch 2.8, the bridge is still compatible with PHP 5.3, so we cannot use ::class here)
GuilhemN
approved these changes
Sep 9, 2018
2aa983e to
2fb11fc
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Sep 18, 2018
…colas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [PhpUnitBridge] enable DebugClassLoader by default | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#10360 With this PR, the phpunit-bridge will enable `DebugClassLoader` by default, making it do its job: throw deprecation notices at autoloading time. On top of #28329, this made me spot some glitches in the code base, fixed here also. This can be disabled by configuring the listener in `phpunit.xml.dist` files, adding `<element key="debug-class-loader"><integer>0</integer></element>` next to `<element key="time-sensitive">...`. Commits ------- 2fb11fc [PhpUnitBridge] enable DebugClassLoader by default
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the phpunit-bridge will enable
DebugClassLoaderby default, making it do its job: throw deprecation notices at autoloading time. On top of #28329, this made me spot some glitches in the code base, fixed here also.This can be disabled by configuring the listener in
phpunit.xml.distfiles, adding<element key="debug-class-loader"><integer>0</integer></element>next to<element key="time-sensitive">....