[Messenger] Change AmqpExt classes constructor signature #28419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75131bf to
2d55ae5
Compare
fabpot
added a commit
that referenced
this pull request
Sep 10, 2018
…re (fabpot) This PR was merged into the 4.2-dev branch. Discussion ---------- [Messenger] Change AmqpExt classes constructor signature | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a This pull requests does 2 things: * It makes `Connection` a first argument of AmqpExt classes. I think it makes sense as this is the most important argument for those classes. * As the `Serializer` is now a second argument, I propose to make it optional and use the default serializer that we've added recently if `null` (`Serializer::create()`) It makes the component even more user friendly when not using Symfony full stack (and provide good defaults). Commits ------- 2d55ae5 [Messenger] changed AmqpExt classes constructor signature
|
Thank you @fabpot. |
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests does 2 things:
It makes
Connectiona first argument of AmqpExt classes. I think it makes sense as this is the most important argument for those classes.As the
Serializeris now a second argument, I propose to make it optional and use the default serializer that we've added recently ifnull(Serializer::create())It makes the component even more user friendly when not using Symfony full stack (and provide good defaults).