[Messenger] Remove message from messenger data collector#28420
Closed
pierredup wants to merge 1 commit intosymfony:masterfrom
Closed
[Messenger] Remove message from messenger data collector#28420pierredup wants to merge 1 commit intosymfony:masterfrom
pierredup wants to merge 1 commit intosymfony:masterfrom
Conversation
e91bc5a to
7e254a8
Compare
Contributor
|
I'm 👎 for this, as it's nothing comparable to the cache collector. All these information are valuable, both for dev and tests, and you usually won't have more than a few messages dispatched per request, with really simple payloads. So I won't fear any big memory increase. |
Contributor
|
Same: 👎. It's a really important information. If the message itself is too big, then that's where the issue is :) Thank you for your time putting a PR together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The messenger data collector currently stores the full message object, which can cause a big increase in memory usage. Based on @nicolas-grekas feedback in #28350 (comment), we should store less information. This PR starts by removing the message object from the profiler and to open the conversation about what information is required in the profiler or what can be optimized.
Before:
After:
