[FrameworkBundle] Ignore backslashes in service ids when using debug:container and debug:autowiring #28487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
respinoza
commented
Sep 17, 2018
•
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28143 |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
20f37b3 to
67763b5
Compare
nicolas-grekas
approved these changes
Sep 17, 2018
|
@nicolas-grekas do we need a doc PR for this? |
|
I'm not sure actually. |
chalasr
approved these changes
Sep 17, 2018
| @@ -13,6 +13,7 @@ CHANGELOG | |||
| * Added new "auto" mode for `framework.session.cookie_secure` to turn it on when HTTPS is used | |||
| * Removed the `framework.messenger.encoder` and `framework.messenger.decoder` options. Use the `framework.messenger.serializer.id` option to replace the Messenger serializer. | |||
| * Deprecated the `ContainerAwareCommand` class in favor of `Symfony\Component\Console\Command\Command` | |||
| * Add the ability to ignore backslashes in service ids when using `debug:container` and `debug:autowiring` | |||
…:container` and `debug:autowiring`
67763b5 to
0aba355
Compare
|
Thank you @respinoza. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 19, 2018
…en using debug:container and debug:autowiring (respinoza) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle] Ignore backslashes in service ids when using debug:container and debug:autowiring | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28143 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Commits ------- 0aba355 [FrameworkBundle] Ignore backslashes in service ids when using `debug:container` and `debug:autowiring`
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.