[Translation] SimpleIntlMessageFormatter for users with no icu extension #28492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvasseur
reviewed
Sep 17, 2018
| namespace Symfony\Component\Translation\Formatter; | ||
|
|
||
| /** | ||
| * A Polyfill for IntlMessageFormatter for users that do not have the icu extension installed. |
There was a problem hiding this comment.
Would it be possible to provide a polyfill for the MessageFormatter class as part of the Intl component (or the intl polyfill) instead?
There was a problem hiding this comment.
I thought about that and I’m not sure I did the correct decision.
The reason why I did not do a polyfill is because I have no intension of being feature complete. There is massive amount of exceptions that you have to consider when supporting multiple languages. Ie number formats and to figure out what “few” means in all languages.
|
I submitted symfony/polyfill#148 instead, would be a better approach IMHO :) |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #27399 we added a IntlMessageFormatter. That only works for users with icu extension installed. Here is a simple implementation of a IntlMessageFormatter. It does not use the icu extension. It is (obviously) not feature complete. I've also chosen to not do it locale specific.