[Yaml] Added support for multiple files or directories in LintCommand #28521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yceruto
commented
Sep 19, 2018
•
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28498 |
| License | MIT |
| Doc PR | symfony/symfony-docs#10367 |
This was referenced Sep 19, 2018
d35c88f to
647f6e3
Compare
xabbuh
reviewed
Sep 20, 2018
| @@ -74,7 +74,8 @@ | |||
| "symfony/translation": "<4.2", | |||
| "symfony/twig-bridge": "<4.1.1", | |||
| "symfony/validator": "<4.1", | |||
| "symfony/workflow": "<4.1" | |||
| "symfony/workflow": "<4.1", | |||
| "symfony/yaml": "<=4.2" | |||
There was a problem hiding this comment.
Done, but still:
- Installing symfony/yaml (4.2.x-dev): Downloading (100%)
There was a problem hiding this comment.
which mean it worked actually
There was a problem hiding this comment.
This is the fails before the last commit https://travis-ci.org/symfony/symfony/jobs/430972569#L2994
|
On master, deps=high failures mean the PR breaks 4.1 when used with deps at 4.2 - this should be fixed somehow (yes, that's the big downside of moving things to components: we now have to deal with cross deps compat...) |
|
Well, here, the issue is only related to the way our CommandTester works. Turning an argument into an array argument is a BC break for tests, because the argument now has to be provided as an array, while there is no BC break when running the command in the CLI. And as FrameworkBundle extends the command and has tests for its child class, it is affected by this change in the argument definition of the component. |
647f6e3 to
ab6d8a1
Compare
|
Could be an alternative to do this in the command |
|
@yceruto you mean reverting the argument type to |
4ef5274 to
11a6498
Compare
nicolas-grekas
approved these changes
Sep 20, 2018
javiereguiluz
approved these changes
Sep 20, 2018
symfony-splitter
pushed a commit
to symfony/translation
that referenced
this pull request
Sep 21, 2018
…ctories in XliffLintCommand (yceruto) This PR was squashed before being merged into the 4.2-dev branch (closes #28522). Discussion ---------- [Translation] Added support for multiple files or directories in XliffLintCommand | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#10368 Same approach of symfony/symfony#28521 Commits ------- 88ec37bed7 [Translation] Added support for multiple files or directories in XliffLintCommand
11a6498 to
d0f7950
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Sep 21, 2018
…ctories in XliffLintCommand (yceruto) This PR was squashed before being merged into the 4.2-dev branch (closes #28522). Discussion ---------- [Translation] Added support for multiple files or directories in XliffLintCommand | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#10368 Same approach of #28521 Commits ------- 88ec37b [Translation] Added support for multiple files or directories in XliffLintCommand
|
Thank you @yceruto. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 21, 2018
… in LintCommand (yceruto) This PR was squashed before being merged into the 4.2-dev branch (closes #28521). Discussion ---------- [Yaml] Added support for multiple files or directories in LintCommand | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28498 | License | MIT | Doc PR | symfony/symfony-docs#10367 Commits ------- d0f7950 [Yaml] Added support for multiple files or directories in LintCommand
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 21, 2018
…ries (yceruto, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [Yaml] Documenting support for multiple files or directories See symfony/symfony#28521 Commits ------- 23f6465 Added the versionadded directive 6cf8bef typo a5546a6 adding missing "or" 1513f22 Added support for multiple files or directories
This was referenced Nov 3, 2018
Closed
Merged
SerhiyMytrovtsiy
added a commit
to SerhiyMytrovtsiy/translation
that referenced
this pull request
Oct 19, 2022
…ctories in XliffLintCommand (yceruto) This PR was squashed before being merged into the 4.2-dev branch (closes #28522). Discussion ---------- [Translation] Added support for multiple files or directories in XliffLintCommand | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#10368 Same approach of symfony/symfony#28521 Commits ------- 88ec37bed7 [Translation] Added support for multiple files or directories in XliffLintCommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.