[PhpUnitBridge] fix disabling DeprecationErrorHandler using phpunit.xml file #28524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| && DeprecationErrorHandler::MODE_WEAK !== $mode | ||
| && DeprecationErrorHandler::MODE_WEAK_VENDORS !== $mode | ||
| && (!isset($mode[0]) || '/' !== $mode[0]) | ||
| ) { |
There was a problem hiding this comment.
indentation should be one level down here
| @@ -54,7 +54,11 @@ public static function register($mode = 0) | |||
| if (false === $mode) { | |||
| $mode = getenv('SYMFONY_DEPRECATIONS_HELPER'); | |||
| } | |||
| if (DeprecationErrorHandler::MODE_WEAK !== $mode && DeprecationErrorHandler::MODE_WEAK_VENDORS !== $mode && (!isset($mode[0]) || '/' !== $mode[0])) { | |||
| if (DeprecationErrorHandler::MODE_DISABLED !== $mode | |||
There was a problem hiding this comment.
please remove trailing spaces (see fabbot failure)
|
@soerenbernstein I suppose you confirm this fixes the issue and allows disabling the bridge using the phpunit.xml file? |
|
Yes. And it will actually set the mode to "disabled" for future use. |
|
Thank you @soerenbernstein. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 20, 2018
…g phpunit.xml file (soerenbernstein) This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #28524). Discussion ---------- [PhpUnitBridge] fix disabling DeprecationErrorHandler using phpunit.xml file Fixing #28519 | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | don't know | Fixed tickets | #28519 | License | MIT Commits ------- 3cd929b [PhpUnitBridge] fix disabling DeprecationErrorHandler using phpunit.xml file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #28519