[Debug] Fix false-positive "MicroKernelTrait::loadRoutes()" method is considered internal" #28553
Conversation
|
I've done the fix in master...GuilhemN:debug-int, I did not realize it was there since 3.4... |
88d6c25 to
4164755
Compare
… considered internal"
4164755 to
46c4f71
Compare
|
'@GuilhemN thanks a lot for having a look! Actually I don't agree with your patch, the test was fine and it's exactly why it was added in #28411. The issue is nastier: we don't deal with traits correctly. This very check you moved up shouldn't exist at all - and we should never inspect method annotations on traits. |
|
Oops sorry, I thought I was the one who introduced it and by mistake 😶 I understand now why you've done this change, I will review your last commit asap :) |
…" method is considered internal" (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [Debug] Fix false-positive "MicroKernelTrait::loadRoutes()" method is considered internal" | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes (fixing and unreleased issue) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28549 | License | MIT | Doc PR | - Introduced in #28411 Just a failing test for now. Commits ------- 46c4f71 [Debug] Fix false-positive "MicroKernelTrait::loadRoutes()" method is considered internal"
|
@GuilhemN thanks for the review. Now merged up to master and green :) |
Introduced in #28411
Just a failing test for now.