[VarDumper] add caster for IntlTimeZone #28559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jschaedl
commented
Sep 22, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28554 |
| License | MIT |
| Doc PR | - |
|
should we add dump getDSTSavings only when useDaylightTime is true? |
|
can be rebased now that #28555 is merged (and thus can leverage castError) |
|
on it |
091f70c to
02d4212
Compare
nicolas-grekas
approved these changes
Sep 23, 2018
|
|
||
| public function testCastIntlTimeZoneWithDST() | ||
| { | ||
| $var = \IntlTimeZone::createTimeZone('Europe/Berlin'); |
There was a problem hiding this comment.
Shouldn't we take another TZ, since we know Europe is going to give up DST next year?
There was a problem hiding this comment.
Yes sure, I totally forgot about that.
07c00af to
c94217c
Compare
|
Thank you @jschaedl. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 23, 2018
This PR was squashed before being merged into the 4.2-dev branch (closes #28559). Discussion ---------- [VarDumper] add caster for IntlTimeZone | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28554 | License | MIT | Doc PR | - Commits ------- c94217c [VarDumper] add caster for IntlTimeZone
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.