Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpFoundation][Security] forward locale and format to subrequests #28565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Sep 23, 2018

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28368, #21546
License MIT
Doc PR -

See discussion in linked issue.

@nicolas-grekas
Copy link
Member Author

(note that Request::duplicate() already preserves the format and the locale - but it's not the way the subrequest is created in these two spots.)

@fabpot
Copy link
Member

fabpot commented Sep 26, 2018

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 41eb191 into symfony:2.8 Sep 26, 2018
fabpot added a commit that referenced this pull request Sep 26, 2018
…brequests (nicolas-grekas)

This PR was merged into the 2.8 branch.

Discussion
----------

[HttpFoundation][Security] forward locale and format to subrequests

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28368, #21546
| License       | MIT
| Doc PR        | -

See discussion in linked issue.

Commits
-------

41eb191 [HttpFoundation][Security] forward locale and format to subrequests
This was referenced Sep 30, 2018
@nicolas-grekas nicolas-grekas deleted the subreq-locale branch October 2, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants