[VarDumper] add casters for IntlDateFormatter and IntlCalendar #28566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jschaedl
commented
Sep 23, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28554 |
| License | MIT |
| Doc PR | - |
cbe0913 to
24b69b3
Compare
| } | ||
|
|
||
| $a += array( | ||
| Caster::PREFIX_VIRTUAL.'time_zone' => $c->getTimeZone(), |
There was a problem hiding this comment.
you're going to be an expert in writing casters :)
here, I'd suggest removing the previous "if" and replace it with this in the big array above:
Caster::PREFIX_VIRTUAL.'time_zone' => ($filter & Caster::EXCLUDE_VERBOSE) ? new CutStub($c->getTimeZone()) : $c->getTimeZone()
(same below)
f004d68 to
8bf4816
Compare
nicolas-grekas
approved these changes
Sep 23, 2018
8bf4816 to
ae76c68
Compare
|
Thank you @jschaedl. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 23, 2018
…Calendar (jschaedl) This PR was squashed before being merged into the 4.2-dev branch (closes #28566). Discussion ---------- [VarDumper] add casters for IntlDateFormatter and IntlCalendar | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28554 | License | MIT | Doc PR | - Commits ------- ae76c68 [VarDumper] add casters for IntlDateFormatter and IntlCalendar
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.