[FrameworkBundle] Deprecate the "--env" and "--no-debug" console options #28653

chalasr · 2018-09-30T18:00:09Z

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	n/a
Deprecations?	yes
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

See #23343 (comment)

fabpot

You should add a note in the UPGRADE/CHANGELOG files

chalasr · 2018-10-01T21:42:36Z

@fabpot done, thanks for the reminder.
Also moved to FrameworkBundle, I've been confused by the console recipe relying on them.

UPGRADE-4.2.md

Koc · 2018-10-02T05:59:03Z

UPGRADE-5.0.md

@@ -116,6 +116,10 @@ FrameworkBundle
 * Added support for the SameSite attribute for session cookies. It is highly recommended to set this setting (`framework.session.cookie_samesite`) to `lax` for increased security against CSRF attacks.
 * The `ContainerAwareCommand` class has been removed, use `Symfony\Component\Console\Command\Command`
   with dependency injection instead.
+ * The `--env` console option and its "-e" shortcut have been deprecated,


In 5.0 this option would removed.

good catch, fixed

fabpot · 2018-10-03T08:46:02Z

Thank you @chalasr.

…g" console options (chalasr) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle] Deprecate the "--env" and "--no-debug" console options | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | n/a | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 9f60ff8 [FrameworkBundle] Deprecate the "--env" and "--no-debug" options

weaverryan · 2018-10-07T14:07:32Z

Can you open a docs issue / pr?

chalasr · 2018-10-07T14:45:32Z

@weaverryan sorry, forgot about it. Just opened symfony/symfony-docs#10444

gnugat · 2018-10-08T11:24:11Z

Hi, I can't seem to be able to find any explanations on this decision, is there a link to a discussion about it somewhere I could be pointed to?

Also BC breaks? has been set as n/a, shouldn't it have been set to "yes" as in Sf 5 scripts using the flag won't be working anymore? Or is it a "no" as currently the only thing we have is warning notice?

Thanks for you answers, and keep up the good work.

ogizanagi · 2018-10-08T12:06:21Z

@gnugat : This was discussed a bit a long time ago. Here is a comment from Fabien mentioning this.
Note there is no BC break here, as it's still supported until 5.0. It'll be considered a BC break when removing it at time master becomes the v5 branch. For now, this is only a deprecation.

gnugat · 2018-10-08T14:26:20Z

@ogizanagi thanks for the link, that's exactly what I was looking for (the description in this PR was empty). Also thanks for the explanation on the BC break policy 👍

chalasr · 2018-10-08T15:50:10Z

@gnugat link added to the PR body, sorry about that

c33s · 2018-10-24T20:15:58Z

this is really a bad decision, it makes the use on windows much more complicated. this is really a very bad DX.

php bin/console --env=dev
Symfony 3.4.12 (kernel: src, env: dev, debug: true)
(fully working symfony console with no errors)

vs

APP_ENV=dev php bin\console
'APP_ENV' is not recognized as an internal or external command,
operable program or batch file.

vs

λ cmd /V /C "set APP_ENV=dev&& php bin\console"
 [WARNING] Some commands could not be registered:
In EnvVarProcessor.php line 76:
  Environment variable not found: "DATABASE_URL_LEGACY".
Symfony 3.4.12 (kernel: src, env: dev, debug: true)
---snip---
In EnvVarProcessor.php line 76:
  Environment variable not found: "APP_SECRET".

also the handy autocomplete possibility with clink on windows and bash-completion on linux is gone with this change. environment variables are cool but not the holy grail for everything. there is a reason for having flags on commands. imagine you have to call all commands like this:

URL=http://example.com RECURSIVE=true OUTPUT_FILE=foo.html wget

please revert this.

nicolas-grekas · 2018-10-24T20:34:00Z

@c33s can you please open a separate issue? Commenting on anything closed is likely going to get low traction.

nicolas-grekas · 2018-11-13T19:15:57Z

Reverted in #29204

@weaverryan

…-env and --no-debug console options (chalasr) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options This reverts commit 9f60ff8. This reverts commit 31b5615. | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28984 | License | MIT | Doc PR | - Working on recipes with @weaverryan, we figured out that this deprecation is just making our life more difficult. Let's revert it. Same as #29126, reverts #28745 and #28653 Commits ------- 443f8ad [FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options

chalasr added the FrameworkBundle label Sep 30, 2018

chalasr added this to the next milestone Sep 30, 2018

carsonbot added Status: Needs Review Feature Deprecation labels Sep 30, 2018

chalasr force-pushed the depr-nodebug-env-opts branch 4 times, most recently from 48a49e1 to 2f92fdd Compare September 30, 2018 19:48

chalasr added Console and removed FrameworkBundle labels Sep 30, 2018

chalasr changed the title ~~[FrameworkBundle] Deprecate the "--env" and "--no-debug" console options~~ [Console] Deprecate the "--env" and "--no-debug" options Sep 30, 2018

chalasr force-pushed the depr-nodebug-env-opts branch from 2f92fdd to 399b5ac Compare September 30, 2018 19:51

dunglas approved these changes Oct 1, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Oct 1, 2018

fabpot requested changes Oct 1, 2018

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Reviewed Status: Needs Work labels Oct 1, 2018

OskarStark approved these changes Oct 1, 2018

View reviewed changes

carsonbot added the Status: Reviewed label Oct 1, 2018

chalasr force-pushed the depr-nodebug-env-opts branch from 399b5ac to 01c4720 Compare October 1, 2018 21:40

chalasr changed the title ~~[Console] Deprecate the "--env" and "--no-debug" options~~ [FrameworkBundle] Deprecate the "--env" and "--no-debug" console options Oct 1, 2018

jvasseur reviewed Oct 1, 2018

View reviewed changes

UPGRADE-4.2.md Show resolved Hide resolved

chalasr force-pushed the depr-nodebug-env-opts branch 4 times, most recently from 161ea03 to 654aa3f Compare October 1, 2018 21:50

chalasr force-pushed the depr-nodebug-env-opts branch from 654aa3f to 7f42065 Compare October 1, 2018 21:51

Koc reviewed Oct 2, 2018

View reviewed changes

[FrameworkBundle] Deprecate the "--env" and "--no-debug" options

9f60ff8

chalasr force-pushed the depr-nodebug-env-opts branch from 7f42065 to 9f60ff8 Compare October 2, 2018 09:07

chalasr modified the milestones: next, 4.2 Oct 2, 2018

fabpot approved these changes Oct 3, 2018

View reviewed changes

fabpot merged commit 9f60ff8 into symfony:master Oct 3, 2018

ogizanagi mentioned this pull request Oct 3, 2018

Allow to override .env files for specific environments symfony/recipes#466

Closed

chalasr deleted the depr-nodebug-env-opts branch October 3, 2018 08:53

chalasr mentioned this pull request Oct 7, 2018

[4.2] --env and --no-debug console options are deprecated symfony/symfony-docs#10444

Closed

ghost mentioned this pull request Oct 10, 2018

[Console] Option -e prod is interpreted as a command when no command is specified #23343

Closed

c33s mentioned this pull request Oct 25, 2018

[FrameworkBundle] Revert deprecation of the "--env" and "--no-debug" console options #28984

Closed

Tobion mentioned this pull request Oct 28, 2018

Remove deprecated "--env" and "--no-debug" console options symfony/recipes#479

Closed

This was referenced Nov 3, 2018

Release v4.2.0-BETA1 #29072

Closed

Release v4.2.0-BETA1 #29073

Merged

nicolas-grekas mentioned this pull request Nov 13, 2018

[FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options #29204

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FrameworkBundle] Deprecate the "--env" and "--no-debug" console options #28653

[FrameworkBundle] Deprecate the "--env" and "--no-debug" console options #28653

chalasr commented Sep 30, 2018 •

edited

Loading

fabpot left a comment

chalasr commented Oct 1, 2018

Koc Oct 2, 2018

chalasr Oct 2, 2018

fabpot commented Oct 3, 2018

weaverryan commented Oct 7, 2018 •

edited

Loading

chalasr commented Oct 7, 2018

gnugat commented Oct 8, 2018

ogizanagi commented Oct 8, 2018 •

edited

Loading

gnugat commented Oct 8, 2018

chalasr commented Oct 8, 2018

c33s commented Oct 24, 2018

nicolas-grekas commented Oct 24, 2018

nicolas-grekas commented Nov 13, 2018

[FrameworkBundle] Deprecate the "--env" and "--no-debug" console options #28653

[FrameworkBundle] Deprecate the "--env" and "--no-debug" console options #28653

Conversation

chalasr commented Sep 30, 2018 • edited Loading

fabpot left a comment

Choose a reason for hiding this comment

chalasr commented Oct 1, 2018

Koc Oct 2, 2018

Choose a reason for hiding this comment

chalasr Oct 2, 2018

Choose a reason for hiding this comment

fabpot commented Oct 3, 2018

weaverryan commented Oct 7, 2018 • edited Loading

chalasr commented Oct 7, 2018

gnugat commented Oct 8, 2018

ogizanagi commented Oct 8, 2018 • edited Loading

gnugat commented Oct 8, 2018

chalasr commented Oct 8, 2018

c33s commented Oct 24, 2018

nicolas-grekas commented Oct 24, 2018

nicolas-grekas commented Nov 13, 2018

chalasr commented Sep 30, 2018 •

edited

Loading

weaverryan commented Oct 7, 2018 •

edited

Loading

ogizanagi commented Oct 8, 2018 •

edited

Loading