[Security] Deprecate simple_preauth and simple_form in favor of Guard #28693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Oct 2, 2018
•
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
9e52873 to
ff0ec61
Compare
fabpot
approved these changes
Oct 3, 2018
| @@ -265,6 +267,10 @@ private function addFirewallsSection(ArrayNodeDefinition $rootNode, array $facto | |||
| ->canBeUnset() | |||
| ; | |||
|
|
|||
| if ($factory instanceof SimplePreAuthenticationFactory || $factory instanceof SimpleFormFactory) { | |||
| $factoryNode->setDeprecated(sprintf('The "%s" security listener is deprecated Symfony 4.2, use "guard" instead.', $name)); | |||
There was a problem hiding this comment.
"use Guard instead" to be consistent everywhere?
| { | ||
| parent::__construct(); | ||
|
|
||
| $this->addOption('authenticator', null); | ||
|
|
||
| if (true === $triggerDeprecation) { |
| */ | ||
| class SimplePreAuthenticationFactory implements SecurityFactoryInterface | ||
| { | ||
| public function __construct(bool $triggerDeprecation = true) | ||
| { | ||
| if (true === $triggerDeprecation) { |
ff0ec61 to
5093b9f
Compare
|
Comments addressed, thanks |
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Oct 3, 2018
… favor of Guard (chalasr) This PR was merged into the 4.2-dev branch. Discussion ---------- [Security] Deprecate simple_preauth and simple_form in favor of Guard | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 5093b9f [Security] Deprecate simple_preauth and simple_form in favor of Guard
This was referenced Nov 3, 2018
Closed
Merged
6 tasks
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 30, 2019
This PR was merged into the 5.0 branch. Discussion ---------- [minor] Removed simple_form and simple_pre_auth As per symfony/symfony#28693 `simple_form` and `simple_pre_auth` has been removed in 5.0 Commits ------- 015d91a Removed simple_form and simple_pre_auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.