[FrameworkBundle] deal with explicitly enabled workflow nodes #28769
Conversation
xabbuh
commented
Oct 8, 2018
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | not yet |
| Fixed tickets | #28662 |
| License | MIT |
| Doc PR |
| http://symfony.com/schema/dic/symfony http://symfony.com/schema/dic/symfony/symfony-1.0.xsd"> | ||
|
|
||
| <framework:config> | ||
| <framework:workflow enabled="true" name="foo" type="workflow" initial-place="bar"> |
There was a problem hiding this comment.
This test currently does not pass. For the other formats the attribute is not configured per workflow but only once. How do we want to handle it in XML? Completely forbidding it? Requiring it to have the same value for each workflow if the attribute is set?
There was a problem hiding this comment.
@symfony/deciders What is your opinion here? :)
There was a problem hiding this comment.
actually what's the meaning of the "enabled" option on the configuration?
as soon as one workflow is defined, workflow is enabled - and if no workflows are defined, it's disabled.
Wouldn't this make sense?
There was a problem hiding this comment.
Generally yes, this option was introduced to be able to explicitly enable the workflow services while not using the config to define your workflows (see #24051 for the context).
There was a problem hiding this comment.
XML are boring for the framework configuration.
I would like instead close #28662 as won't fix. Use should use the "regular" way to define workflow.
There was a problem hiding this comment.
Anyway, I would go for supporting
<framework:workflow enabled="true" />
or your current exemple without enabled="true"
and that's all
|
The extension now throws when Status: Needs Review |
|
... and one more bug fixed, thank you Christian. |
…des (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] deal with explicitly enabled workflow nodes | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | not yet | Fixed tickets | #28662 | License | MIT | Doc PR | Commits ------- 017fd56 deal with explicitly enabled workflow nodes