Invalidate Translator cache when new translation files are added #28773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just before writing the Translator cache, find out in which directories the translation files were found, and add those directories as resources for the catalogue so that when a new file appears in one of those directories the catalogue cache will be invalidated. This may cause some false positives in case non-translation files are in those directories, but since the recommendation is to keep translations on their own, it should not happen.
cc9aab5 to
9e68874
Compare
|
Not 100% sure if I like the implementation, but it does work (tested in a real app). Also, if anyone has an idea on how to write a test for this I'd like to hear it. From what I can see the caching part isn't under test at all? |
|
This approach was actually rather hacky and also incorrect because it assumed that new translation files would only be found in directories that current translation files were found in, which isn't necessarily the case; they might be added to other directories as well. Therefore I've just opened a new PR that solves this problem correctly (#28937) and I'll close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just before writing the Translator cache, find out in which directories
the translation files were found, and add those directories as resources
for the catalogue so that when a new file appears in one of those
directories the catalogue cache will be invalidated.
This may cause some false positives in case non-translation files are in
those directories, but since the recommendation is to keep translations
on their own, it should not happen.