[HttpFoundation] Make ResponseHeaderBag::makeDisposition static #28807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Oct 10, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes-ish |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #27851 |
| License | MIT |
| Doc PR | n/a |
0dbb78a to
4c4ad02
Compare
| * @throws \InvalidArgumentException | ||
| * | ||
| * @see RFC 6266 | ||
| * @see HeaderUtils::makeDisposition() | ||
| */ | ||
| public function makeDisposition($disposition, $filename, $filenameFallback = '') |
There was a problem hiding this comment.
shall we deprecate then?
OskarStark
reviewed
Oct 10, 2018
| * | ||
| * @see RFC 6266 | ||
| */ | ||
| public static function makeDisposition($disposition, $filename, $filenameFallback = '') |
There was a problem hiding this comment.
why not using null as default here?
There was a problem hiding this comment.
I've just moved the code and don't want to make other changes.
There was a problem hiding this comment.
Makes sense 👍
Thank you!
There was a problem hiding this comment.
IMO new code should have type declarations.
OskarStark
reviewed
Oct 10, 2018
| * | ||
| * @param string $disposition One of "inline" or "attachment" | ||
| * @param string $filename A unicode string | ||
| * @param string $filenameFallback A string containing only ASCII characters that |
There was a problem hiding this comment.
IMO $fallback would be enough in this context
OskarStark
approved these changes
Oct 10, 2018
javiereguiluz
approved these changes
Oct 11, 2018
4c4ad02 to
03471a3
Compare
03471a3 to
d29b410
Compare
fabpot
added a commit
that referenced
this pull request
Oct 15, 2018
…on static (fabpot) This PR was merged into the 4.2-dev branch. Discussion ---------- [HttpFoundation] Make ResponseHeaderBag::makeDisposition static | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes-ish | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes | Fixed tickets | #27851 | License | MIT | Doc PR | n/a <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- d29b410 [HttpFoundation] made ResponseHeaderBag::makeDisposition static
fabpot
added a commit
that referenced
this pull request
Oct 15, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [HttpFoundation] Publicify new consts | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Continuation of #28807 I think it's reasonable to enforce visibility for new consts, ideally solved by PHP-CS-Fixer. This makes it explicit for the consts to be consumed as part of public API. Commits ------- ce95d0d [HttpFoundation] Publicify new consts
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.