[VarDumper] Scroll into view when searching #28854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Positioning it fixed relative to the main |
Maybe using flex display will do? But no blocker for me.. the keyboard shortcuts work either way. |
|
Actually I don't see how using a flex display could help for this :/ |
|
👍 for a fixed top bar, that reduces the possible min. width as well. Let me know if i should have a look in this PR. |
|
friendly ping for 4.2 as-is :) |
fabpot
approved these changes
Oct 27, 2018
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Oct 27, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [VarDumper] Scroll into view when searching | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> This jumps to the found element when using the javascript widget for searching HTML dumps. Inspired by Ctrl+F in Chrome :) It's super convenient with long dumps, however i wasnt able to position the search input on the right in a fixed manner... because CSS 😓 i was hoping @ogizanagi could add a patch for it. Also see https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView Commits ------- 647a937 [VarDumper] Scroll into view when searching
This was referenced Nov 3, 2018
Closed
Merged
Closed
nicolas-grekas
added a commit
that referenced
this pull request
Jan 27, 2019
This PR was squashed before being merged into the 4.2 branch (closes #29984). Discussion ---------- [VarDumper] Fixed search bar | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Continuation of #28854, replaces #29176 initial:  ctrl f:  scroll:  tested in chrome+ff cc @ogizanagi ref https://caniuse.com/#feat=css-sticky Commits ------- 99d2893 [VarDumper] Fixed search bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This jumps to the found element when using the javascript widget for searching HTML dumps. Inspired by Ctrl+F in Chrome :)
It's super convenient with long dumps, however i wasnt able to position the search input on the right in a fixed manner... because CSS 😓 i was hoping @ogizanagi could add a patch for it.
Also see https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView