[HttpKernel] Introduce KernelInterface::getProjectDir() #28901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Oct 17, 2018
| @@ -21,6 +21,8 @@ | |||
| * It manages an environment made of application kernel and bundles. | |||
| * | |||
| * @author Fabien Potencier <[email protected]> | |||
| * | |||
| * @method string getProjectDir() | |||
There was a problem hiding this comment.
let's add a description, eg:
@method string getProjectDir() Gets the application root dir (path of the project's composer file) - not defining it is deprecated since Symfony 4.2
There was a problem hiding this comment.
it works. can you do a github suggestion? Im so curious about that :D
fabpot
requested changes
Oct 17, 2018
| @@ -21,6 +21,8 @@ | |||
| * It manages an environment made of application kernel and bundles. | |||
| * | |||
| * @author Fabien Potencier <[email protected]> | |||
| * | |||
| span class="pl-s1"> * @method string getProjectDir() Gets the project dir (path of the project's composer file) - not defining it is deprecated since Symfony 4.2 | |||
There was a problem hiding this comment.
it failed :)
can you squash also please?
nicolas-grekas
approved these changes
Oct 17, 2018
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Oct 17, 2018
…(ro0NL) This PR was merged into the 4.2-dev branch. Discussion ---------- [HttpKernel] Introduce KernelInterface::getProjectDir() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | not yet | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #28897 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Removes the last call to getParameter('kernel.project_dir') during runtime in core. Yay :) cc @fabpot @nicolas-grekas Commits ------- b046f41 [HttpKernel] Introduce KernelInterface::getProjectDir()
fabpot
added a commit
that referenced
this pull request
Jan 5, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #28902). Discussion ---------- [Debug] Detect virtual methods using @method | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #28897 (comment) | License | MIT | Doc PR | symfony/symfony-docs#10504 My first Debug PR, so im still on it. But early feedback welcome. In #28901 we'll introduce a new virtual interface method using `@method` annotation. IIUC the idea is to trigger whenever such a method is overridden. Commits ------- 38877c3 [Debug] Detect virtual methods using @method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the last call to getParameter('kernel.project_dir') during runtime in core. Yay :)
cc @fabpot @nicolas-grekas