[WebProfilerBundle] Add channel log filter #28934
Conversation
| @@ -7,7 +9,7 @@ | |||
| --font-sans-serif: 'Helvetica, Arial, sans-serif'; | |||
| --page-background: #f9f9f9; | |||
| --color-text: #222; | |||
| --color-muted: #777; | |||
| --color-muted: #999; | |||
There was a problem hiding this comment.
this var was overwritten below
| @@ -28,7 +30,6 @@ | |||
| --table-header: #e0e0e0; | |||
| --shadow: 0px 0px 1px rgba(128, 128, 128, .2); | |||
| --border: 1px solid #e0e0e0; | |||
| --color-muted: #999; | |||
| @@ -892,9 +893,6 @@ tr.status-warning td { | |||
| background-color: var(--base-5); | |||
| color: var(--base-2); | |||
| } | |||
| .tab-content { | |||
There was a problem hiding this comment.
not needed, now specified by [data-filters] (the container that requires it)
| @@ -958,45 +991,6 @@ table.logs .metadata { | |||
| display: block; | |||
| font-size: 12px; | |||
| } | |||
| table.logs tr td:last-child { width: 100%; } | |||
There was a problem hiding this comment.
already handled by .full-width on the message TH
|
Great work Roland! I've tested this in the Symfony Demo app. I only have minor remarks. First: "Ghost filters": when loading the page, filters are displayed by default and they disappear when they shouldn't be displayed. This GIF shows a force reload in the page:
Maybe it's better to "hide by default" and display when appropriate? Second: "Moving filters": Right now, the multiple choice filters "move" under some circumstances. See hwen I deselect all of channels and icons disappear:
This kind of movements are distracting and user may click wrongly because of these element displacements. What if we replace the showing/hiding icon by a form checkbox? It doesn't have to be a real form, just a clickable checkbox. Stripe does something similar:
|
|
I think i've addressed both issues.
|
|
Thank you @ro0NL. |
This PR was squashed before being merged into the 4.2-dev branch (closes #28934). Discussion ---------- [WebProfilerBundle] Add channel log filter | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Continuation of #28906 The JS is revised to be more generic; - support 2 filter types: `level` and `choice` (respectively `Log level` and `Log channel` here) - remove default filter value support (not used yet, but opportunity kept open) - it requires a bit more work to genericify it. - filters refines the resultset (e.g. show all logs in the app channel with priority higher than alert)  Level filter (works the same as shown in #28906 )  Choice filter   We forgot to update TwigBundle previously, that's still needed after review here. Commits ------- e1bd82e [WebProfilerBundle] Add channel log filter
Continuation of #28906
The JS is revised to be more generic;
levelandchoice(respectivelyLog levelandLog channelhere)Level filter (works the same as shown in #28906 )
Choice filter
We forgot to update TwigBundle previously, that's still needed after review here.