[Messenger] Add StackInterface, allowing to unstack the call stack
#28943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72ecf16 to
c3002e0
Compare
ro0NL
reviewed
Oct 23, 2018
| @@ -23,11 +23,3 @@ | |||
| */ | |||
| public function handle(Envelope $envelope, callable $next): void; | |||
There was a problem hiding this comment.
worth to describe the callable signature / different modes in the phpdoc?
There was a problem hiding this comment.
ah it's pretty clear in NextInterface, @see NextInterface maybe?
There was a problem hiding this comment.
that's what the @param annotation already links to to me
c3002e0 to
732be7f
Compare
sroze
suggested changes
Oct 25, 2018
|
Maybe we can simplify the public function handle(Envelope $envelope, StackInterface $stack): Envelope
{
// ...
return $stack->next()->handle($envelope, $stack);
} |
stof
reviewed
Oct 25, 2018
| return $middleware; | ||
| } | ||
|
|
||
| public function handle(Envelope $envelope, callable $next): void |
There was a problem hiding this comment.
why should this class implement MiddlewareInterface ? Calling it as a middleware does not make sense
38326a7 to
ccce2b8
Compare
I love that ;) @stof that fixes also your comment. |
NextInterface, allowing to unstack the call stackStackInterface, allowing to unstack the call stack
ccce2b8 to
09eff3d
Compare
09eff3d to
2bc7d11
Compare
sroze
approved these changes
Oct 25, 2018
|
Thank you @nicolas-grekas. |
sroze
added a commit
that referenced
this pull request
Oct 25, 2018
…the call stack (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Messenger] Add `StackInterface`, allowing to unstack the call stack | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - At the moment, debugging an exception coming from a middleware is not as friendly as it could: each middleware is preceded by a noisy frame added by the `$next` callable indirection. This PR allows removing this frame by using `$next()->handle($envelope, $next);` instead of `$next($envelope);` in a middleware. Note that this is optional so that the later continues to work. But if one wants to opt-in for the former, then the stack trace of exceptions will be freed from `$next`. All core middleware should do this, so here they are, updated. Commits ------- 2bc7d11 [Messenger] Add `StackInterface`, allowing to unstack the call stack
fabpot
added a commit
that referenced
this pull request
Oct 27, 2018
…agi) This PR was merged into the 4.2-dev branch. Discussion ---------- [Messenger] Move MiddlewareTestCase in Test ns | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes (AppVeyor failure unrelated) <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Just a quick suggestion after #28943 being merged. Wouldn't it make sense to move this in `Test` namespace to be used by anyone wanting to unit test their middleware? Commits ------- 215c895 [Messenger] Move MiddlewareTestCase in Test ns
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, debugging an exception coming from a middleware is not as friendly as it could: each middleware is preceded by a noisy frame added by the
$nextcallable indirection.This PR allows removing this frame by using
$next()->handle($envelope, $next);instead of$next($envelope);in a middleware. Note that this is optional so that the later continues to work. But if one wants to opt-in for the former, then the stack trace of exceptions will be freed from$next.All core middleware should do this, so here they are, updated.