[Messenger] remove classifying sub-namespaces in favor of semantic ones #28947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8accff4 to
34a8c2d
Compare
d024de9 to
1a3c57e
Compare
1a3c57e to
640cced
Compare
ogizanagi
reviewed
Oct 22, 2018
There was a problem hiding this comment.
Completely makes sense to me.
How do you feel with the AmqpExt in the Messenger/Transport ns? Where would live the Memory/KernelTerminateTransport and upcoming transport bridges/implems if any?
| use Symfony\Component\Messenger\Transport\Enhancers\StopWhenMemoryUsageIsExceededReceiver; | ||
| use Symfony\Component\Messenger\Transport\Enhancers\StopWhenMessageCountIsExceededReceiver; | ||
| use Symfony\Component\Messenger\Transport\Enhancers\StopWhenTimeLimitIsReachedReceiver; | ||
| use Symfony\Component\Messenger\Transport\StopWhenMemoryUsageIsExceededReceiver; |
There was a problem hiding this comment.
- Symfony\Component\Messenger\Transport\StopWhenMemoryUsageIsExceededReceiver
+ Symfony\Component\Messenger\Transport\Receiver\StopWhenMemoryUsageIsExceededReceiver(same for the two ones below)
I think they're OK in their own sub-namespace - same for other future transports - unless they need just one class I suppose. |
640cced to
350a20c
Compare
ogizanagi
approved these changes
Oct 22, 2018
xabbuh
approved these changes
Oct 24, 2018
chalasr
approved these changes
Oct 24, 2018
|
The suffix Decorator on |
350a20c to
9d8a666
Compare
makes sense, removed. |
9d8a666 to
16afb5e
Compare
|
Thank you @nicolas-grekas. |
sroze
added a commit
that referenced
this pull request
Oct 25, 2018
… of semantic ones (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Messenger] remove classifying sub-namespaces in favor of semantic ones | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - While working on the component, I found it hard to discover the meaning of the `Asynchronous` and `Enhancers` sub-namespaces. Now that I know the component better, I understand they're only classifying namespaces with no specific technical semantics. I'd like to remove them to make the component easier to discover. This PR introduces a few new semantic sub-namespaces instead. From the changelog: * Classes in the `Middleware\Enhancers` sub-namespace have been moved to the `Middleware` one * Classes in the `Asynchronous\Routing` sub-namespace have been moved to the `Transport\Sender\Locator` sub-namespace * The `Asynchronous/Middleware/SendMessageMiddleware` class has been moved to the `Middleware` namespace * `SenderInterface` and `ChainSender` classes have been moved to the `Transport\Sender` sub-namespace * `ReceiverInterface` and its implementations have been moved to the `Transport\Receiver` sub-namespace Commits ------- 16afb5e [Messenger] remove classifying sub-namespaces in favor of semantic ones
This was referenced Oct 25, 2018
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the component, I found it hard to discover the meaning of the
AsynchronousandEnhancerssub-namespaces. Now that I know the component better, I understand they're only classifying namespaces with no specific technical semantics.I'd like to remove them to make the component easier to discover.
This PR introduces a few new semantic sub-namespaces instead.
From the changelog:
Middleware\Enhancerssub-namespace have been moved to theMiddlewareoneAsynchronous\Routingsub-namespace have been moved to theTransport\Sender\Locatorsub-namespaceAsynchronous/Middleware/SendMessageMiddlewareclass has been moved to theMiddlewarenamespaceSenderInterfaceandChainSenderclasses have been moved to theTransport\Sendersub-namespaceReceiverInterfaceand its implementations have been moved to theTransport\Receiversub-namespace