[Process] fix waitUntil+add tests #28958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Oct 23, 2018
| Q | A |
|---|---|
| Branch? | 4.2 |
| Bug fix? | yes |
| New feature? | |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
Nek-
reviewed
Oct 23, 2018
| @@ -160,6 +161,13 @@ public function testWaitUntilSpecificOutput() | |||
| $this->assertEquals("First iteration output\nSecond iteration output\nOne more iteration output\n", $completeOutput); | |||
| } | |||
|
|
|||
| public function testWaitUntilReturnspecificOutput() | |||
There was a problem hiding this comment.
I guess the name of this test is not accurate. (It test what happen in case the process ends fast, isn't it?)
16d720d to
946d278
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Oct 23, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [Process] fix waitUntil+add tests | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 946d278 [Process] fix waitUntil+add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.