[TwigBridge] Remove $rootDir argument in CodeExtension #28967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
commented
Oct 24, 2018
| * @param string $charset The charset | ||
| */ | ||
| public function __construct($fileLinkFormat, string $rootDir, string $charset, string $projectDir = null) | ||
| public function __construct($fileLinkFormat, string $projectDir, string $charset) |
There was a problem hiding this comment.
argument was added in 4.2, so safe to remove technically.
We slightly change the behavior, only in formatFile. IMHO that's fine.
|
can you have a look at the failure on Windows? |
|
and the failure on Travis btw - looks like the composer.json change allowed spotting an issue :) |
|
Im not sure the appveyor failure is still related, looks like it's not. |
|
The so i tend to keep the slash normalization actually =/ |
Tobion
approved these changes
Oct 25, 2018
fabpot
approved these changes
Oct 25, 2018
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Oct 25, 2018
…0NL) This PR was merged into the 4.2-dev branch. Discussion ---------- [TwigBridge] Remove $rootDir argument in CodeExtension | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | symfony/symfony-docs#10547 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Forgotten in #28890 cc @javiereguiluz Commits ------- f894724 [TwigBridge] Remove $rootDir argument in CodeExtension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgotten in #28890
cc @javiereguiluz