[FrameworkBundle] make debug:autowiring list useful services and their description #28970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfe8e04 to
b44a7f4
Compare
ro0NL
reviewed
Oct 25, 2018
ro0NL
reviewed
Oct 25, 2018
bcd423f to
2fb426f
Compare
chalasr
approved these changes
Oct 26, 2018
weaverryan
approved these changes
Oct 26, 2018
chalasr
reviewed
Oct 26, 2018
| * @param string $class | ||
| * | ||
| * @return string | ||
| * @internal |
There was a problem hiding this comment.
the whole sub-namespace is internal, can be removed
2fb426f to
56aab09
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Oct 29, 2018
…rvices and their description (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle] make debug:autowiring list useful services and their description | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27207 | License | MIT | Doc PR | - This PR closes #27207: we don't need "semantics" anymore. 4.2 has everything already to allow us to separate useful services from the other ones: any autowireable *alias* **is** a useful service! Add autowiring by type + parameter name (#28234) and the story is done: we can easily hint people about which features their bundles provide, without being polluted by for-wiring-only services. Here is a screenshot running this command(before I excluded the aliases for $cacheApp and $cacheSystem):  ping @weaverryan as we drafted that together. Fixes a few issues found meanwhile. That should definitely go in 4.2. Commits ------- 56aab09 [FrameworkBundle] make debug:autowiring list useful services and their description
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #27207: we don't need "semantics" anymore. 4.2 has everything already to allow us to separate useful services from the other ones: any autowireable alias is a useful service!
Add autowiring by type + parameter name (#28234) and the story is done: we can easily hint people about which features their bundles provide, without being polluted by for-wiring-only services.
Here is a screenshot running this command(before I excluded the aliases for $cacheApp and $cacheSystem):
ping @weaverryan as we drafted that together.
Fixes a few issues found meanwhile.
That should definitely go in 4.2.