Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Messenger] Move MiddlewareTestCase in Test ns #28985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2018
Merged

[Messenger] Move MiddlewareTestCase in Test ns #28985

merged 1 commit into from
Oct 27, 2018

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Oct 25, 2018 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes (AppVeyor failure unrelated)
Fixed tickets N/A
License MIT
Doc PR N/A

Just a quick suggestion after #28943 being merged. Wouldn't it make sense to move this in Test namespace to be used by anyone wanting to unit test their middleware?

@nicolas-grekas nicolas-grekas added this to the next milestone Oct 27, 2018
sroze
sroze approved these changes Oct 27, 2018
View reviewed changes
Copy link
Contributor

@sroze sroze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, sounds reasonable to me.

@ro0NL
Copy link
Contributor

ro0NL commented Oct 27, 2018

should we actually use it? #28999

@ogizanagi
Copy link
Contributor Author

@ro0NL : Done and added MiddlewareTestCase::getThrowingStackMock().
Thanks for pointing this out

@fabpot
Copy link
Member

fabpot commented Oct 27, 2018

Thank you @ogizanagi.

@fabpot fabpot merged commit 215c895 into symfony:master Oct 27, 2018
fabpot added a commit that referenced this pull request Oct 27, 2018
@fabpot
feature #28985 [Messenger] Move MiddlewareTestCase in Test ns (ogizan…
b6758e9 
…agi)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[Messenger] Move MiddlewareTestCase in Test ns

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes (AppVeyor failure unrelated)    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Just a quick suggestion after #28943 being merged. Wouldn't it make sense to move this in `Test` namespace to be used by anyone wanting to unit test their middleware?

Commits
-------

215c895 [Messenger] Move MiddlewareTestCase in Test ns
@ogizanagi ogizanagi deleted the messenger/middleware_test_case branch October 27, 2018 18:15
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.2 Nov 1, 2018
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sroze sroze sroze approved these changes

@ro0NL ro0NL ro0NL approved these changes

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr chalasr approved these changes

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Feature Messenger Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
8 participants
@ogizanagi @ro0NL @fabpot @sroze @xabbuh @chalasr @nicolas-grekas @carsonbot