Fix wrong loop in Process::wait() method #29021
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The while condition was the opposite of the previous while. This was obviously leading to the death of this loop. Loop which was useful according to some people (see symfony#28940), so I just moved the code to the right position.
1fcbc53 to
b038eb2
Compare
|
bug fix => 2.8 yes :) |
|
nevermind; this fix is wrong. Everything is useful here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The while condition was the opposite of the previous while. This was obviously leading to the death of this loop. Loop which was useful according to some people (see #28940), so I just moved the code to the right position.
I tested some process execution in order to be sure the code is never executed. I also noticed that there's no CPU issue without this sleep (kubuntu 18.04 / intel i7 2k):
