[Cache] allow to skip saving the computed value when using CacheInterface::get() #29022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to play with using Messenger and Cache together, I spotted a few issues related to the new
CacheInterface::get()
method:LockRegistry
: processes that wait for the lock to be released should not write the value back when the lock is over. This is addressed by adding a 2ndbool &$save
argument to the computing callback. When the callback sets this reference to true, the returned value should not be written to the pool.CallbackInterface
is added in theContracts\Cache
namespace. This will help autocompletion and implementations.ContractsTrait
was writing twice the value to the pool - now fixedLockRegistry
did not retry locking when a waiting process wasn't able to fetch the fresh value - now fixed.