[DI] use filter_var() instead of XmlUtils::phpize() in EnvVarProcessor #29042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Oct 31, 2018
dunglas
approved these changes
Nov 1, 2018
Taluu
approved these changes
Nov 2, 2018
| @@ -90,19 +89,19 @@ public function getEnv($prefix, $name, \Closure $getEnv) | |||
| } | |||
|
|
|||
| if ('bool' === $prefix) { | |||
| return (bool) self::phpize($env); | |||
| return (bool) (filter_var($env, FILTER_VALIDATE_BOOLEAN) ?: filter_var($env, FILTER_VALIDATE_INT) ?: filter_var($env, FILTER_VALIDATE_FLOAT)); | |||
There was a problem hiding this comment.
why allow ints or floats to be casted as bool, and not limit to bools only ?
There was a problem hiding this comment.
Because that's supported+tested today, and we shouldn't break BC.
fabpot
approved these changes
Nov 2, 2018
|
merging into master as this is not a bug. |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 2, 2018
… EnvVarProcessor (nicolas-grekas) This PR was submitted for the 3.4 branch but it was merged into the 4.2-dev branch instead (closes #29042). Discussion ---------- [DI] use filter_var() instead of XmlUtils::phpize() in EnvVarProcessor | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - #29041 made me realize that we don't need this dependency on the Config component: `filter_var()` is just fine. This allows using a few more legit values for boolean styles, which are already accepted in php.ini Commits ------- ce53261 [DI] use filter_var() instead of XmlUtils::phpize() in EnvVarProcessor
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29041 made me realize that we don't need this dependency on the Config component:
filter_var()is just fine. This allows using a few more legit values for boolean styles, which are already accepted in php.ini