[OptionsResolver] Micro optimizations and simplifications #29065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe improving this #29055 |
52d60c7 to
4340c4e
Compare
4340c4e to
24c2213
Compare
nicolas-grekas
approved these changes
Nov 6, 2018
|
Thank you @yceruto. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 10, 2018
…s (yceruto) This PR was merged into the 4.2-dev branch. Discussion ---------- [OptionsResolver] Micro optimizations and simplifications | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29055 | License | MIT | Doc PR | - As we know, this component has a big impact on the workflow of the `Form` component. I'm a newcomer in Blackfire, so there could be other optimizations that I can't able to see, but here we go. For now, we've less code to maintain  and a micro-optimizacion of performance. It'd be great if someone could try these changes in a real project to see their real value.   https://blackfire.io/profiles/compare/a04a13d3-7f60-4434-a2b8-0762efb8fbd6/graph https://github.com/yceruto/orbf The sample takes into account only the core extensions. Cheers! Commits ------- 24c2213 Optimizations and simplifications OMG Blackfire!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we know, this component has a big impact on the workflow of the
Formcomponent. I'm a newcomer in Blackfire, so there could be other optimizations that I can't able to see, but here we go.For now, we've less code to maintain
and a micro-optimizacion of performance. It'd be great if someone could try these changes in a real project to see their real value.
https://blackfire.io/profiles/compare/a04a13d3-7f60-4434-a2b8-0762efb8fbd6/graph
https://github.com/yceruto/orbf The sample takes into account only the core extensions.
Cheers!