Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Travis] Bump ext-mongodb to 1.5.2 on Travis #29099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2018
Merged

[Travis] Bump ext-mongodb to 1.5.2 on Travis #29099

merged 1 commit into from
Nov 6, 2018

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Nov 5, 2018

Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets https://travis-ci.org/symfony/symfony/jobs/451058906#L2679
License MIT
Doc PR N/A

Should fix Travis builds after mongodb/mongo-php-library@ba0b611 being merged (but not released yet).

And/or use composer require --dev --no-update mongodb/mongodb:@stable?

@ogizanagi ogizanagi changed the base branch from 2.8 to 2.7 November 6, 2018 07:06
@ogizanagi
Copy link
Contributor Author

ogizanagi commented Nov 6, 2018

Rebased to 2.7, as it still receives security fixes.

@ogizanagi ogizanagi changed the title Bump ext-mongodb to 1.5.2 on Travis [Travis] Bump ext-mongodb to 1.5.2 on Travis Nov 6, 2018
@nicolas-grekas nicolas-grekas added this to the 2.8 milestone Nov 6, 2018
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(merging in 2.8: this is not a security fix)

@nicolas-grekas nicolas-grekas changed the base branch from 2.7 to 2.8 November 6, 2018 15:30
@nicolas-grekas
Copy link
Member

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit 6e4af32 into symfony:2.8 Nov 6, 2018
nicolas-grekas added a commit that referenced this pull request Nov 6, 2018
This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #29099).

Discussion
----------

[Travis] Bump ext-mongodb to 1.5.2 on Travis

| Q             | A
| ------------- | ---
| Branch?       | 2.7 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | https://travis-ci.org/symfony/symfony/jobs/451058906#L2679   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Should fix Travis builds after mongodb/mongo-php-library@ba0b611 being merged (but not released yet).

And/or use `composer require --dev --no-update mongodb/mongodb:@stable`?

Commits
-------

6e4af32 [Travis] Bump ext-mongodb to 1.5.2 on Travis
@ogizanagi ogizanagi deleted the bump-mongo branch November 6, 2018 16:20
@ogizanagi
Copy link
Contributor Author

@nicolas-grekas : I didn't mean this is a security fix, sorry 😅
But don't we want the CI to be reliable when merging security fixes? Cf yourself in #28110 :)

@nicolas-grekas
Copy link
Member

That was before we had private CI for security patches :)

@stof
Copy link
Member

stof commented Nov 6, 2018

@nicolas-grekas we would still need a working CI, even if it runs on the private repo.

@nicolas-grekas
Copy link
Member

Sure, what I mean is that this should be dealt with in the patch fixing a security issue.a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants