Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Workflow] Trigger entered event for subject entering in the Workflow for the first time#29145

Merged
nicolas-grekas merged 1 commit intosymfony:masterfrom
lyrixx:workflow-initial-place
Dec 1, 2018
Merged

[Workflow] Trigger entered event for subject entering in the Workflow for the first time#29145
nicolas-grekas merged 1 commit intosymfony:masterfrom
lyrixx:workflow-initial-place

Conversation

@lyrixx
Copy link
Member

@lyrixx lyrixx commented Nov 8, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28319
License MIT
Doc PR

@nicolas-grekas nicolas-grekas added this to the next milestone Nov 8, 2018
nicolas-grekas
nicolas-grekas approved these changes Dec 1, 2018
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please submit a doc PR if applicable

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Dec 1, 2018

Thank you @lyrixx.

@nicolas-grekas nicolas-grekas merged commit 388840f into symfony:master Dec 1, 2018
nicolas-grekas added a commit that referenced this pull request Dec 1, 2018
@nicolas-grekas
feature #29145 [Workflow] Trigger entered event for subject enterin…
905119b 
…g in the Workflow for the first time (lyrixx)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Workflow] Trigger `entered` event for subject entering in the Workflow for the first time

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28319
| License       | MIT
| Doc PR        |

Commits
-------

388840f [Workflow] Trigger `entered` event for subject entering in the Workflow for the first time
@lyrixx lyrixx deleted the workflow-initial-place branch December 3, 2018 17:28
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@fabpot fabpot mentioned this pull request May 9, 2019
Merged
@florentdestremau florentdestremau mentioned this pull request Nov 29, 2019
Closed
@lstrojny
Copy link
Contributor

lstrojny commented Apr 28, 2020 •
edited
Loading

I think this should be considered a BC break since it changes the signature of Workflow\Event::getTransition() from getTransition(): Transition to getTransition(): Transition|null.

@lyrixx
Copy link
Member Author

lyrixx commented Apr 28, 2020

There was not typehint nor PHPDoc on this method, so I guess this was not a BC break.
More over, this has been merged 2 year ago and you are the first one to report that, so I guess this is fine.

@lstrojny
Copy link
Contributor

lstrojny commented Apr 28, 2020

The argument that a lack of PHPDoc makes it not a BC break doesn’t sound convincing to me as one wouldn't realistically expect users to assume getTransition(): mixed before Symfony 4.3. And yes, it’s probably too late anyway to do anything about it. I don't know what the practice it but adding it to the 4.3 upgrade guide might be a good idea.

@xabbuh
Copy link
Member

xabbuh commented Apr 29, 2020

I think adding this to the upgrade file is a good idea as changing this again is too late. @lstrojny Would you like to send a PR changing the UPGRADE-4.3.md file (on the 4.4` branch)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees

No one assigned

Labels

Feature Status: Reviewed Workflow

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@lyrixx @nicolas-grekas @lstrojny @xabbuh @carsonbot