[Console] Add hyperlinks support#29168
Merged
fabpot merged 1 commit intosymfony:masterfrom Dec 10, 2018
Merged
Conversation
This was referenced Nov 10, 2018
Contributor
|
Oh you actually went and figured it out. Great work @ostrolucky! 👍 |
Member
|
Wow! We need this in CliDumper also! |
Contributor
|
Does it support |
Contributor
Author
|
This PR doesn't use this functionality, it only enables its usage. Screenshot was just potential scenario, it would require work outside the scope. |
src/Symfony/Component/Console/Formatter/OutputFormatterStyle.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Console/Tests/Formatter/OutputFormatterTest.php
Outdated
Show resolved
Hide resolved
Member
|
Do we have any case where wrapping could need using the "id" attribute described in the linked doc? |
Contributor
Author
|
I don't |
e29f77b to
55ffa6e
Compare
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
LGTM with one minor comment.
Can you please add a line in the changelog file of the component + create a doc issue/PR?
src/Symfony/Component/Console/Formatter/OutputFormatterStyle.php
Outdated
Show resolved
Hide resolved
fabpot
reviewed
Dec 8, 2018
fabpot
approved these changes
Dec 10, 2018
Member
|
@ostrolucky Can you submit a PR on the docs to document this new feature? |
f1d658d to
db750ed
Compare
Member
|
Thank you @ostrolucky. |
fabpot
added a commit
that referenced
this pull request
Dec 10, 2018
This PR was squashed before being merged into the 4.3-dev branch (closes #29168). Discussion ---------- [Console] Add hyperlinks support | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21207 | License | MIT | Doc PR | For details about this see https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda Here's one idea/use case which could utilize this feature (not implemented in this PR as it requires more work)  I checked this in cmd.exe as well and no sideffects there Commits ------- db750ed [Console] Add hyperlinks support
nicolas-grekas
added a commit
that referenced
this pull request
Dec 13, 2018
…s-grekas) This PR was merged into the 4.3-dev branch. Discussion ---------- [VarDumper] add support for links in CliDumper | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Same as #29168 for VarDumper:  Thanks @ostrolucky for this nice discovery! Commits ------- e7cd44f [VarDumper] add support for links in CliDumper
nicolas-grekas
added a commit
that referenced
this pull request
Dec 20, 2018
This PR was merged into the 4.3-dev branch. Discussion ---------- [VarDumper] Use hyperlinks in CliDescriptor | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | Part of #29585 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Leverages #29168 to add the hyperlink directly on the source text instead of printing below: #### Before (or with `symfony/console < 4.3`)  #### After  Commits ------- e54e219 [VarDumper] Use hyperlinks in CliDescriptor
Merged
|
Not sure If it's a console component bug .. I'm using iTerm2 and after upgrading to 4.3-Beta I realised debug:router now returns link in the path output. But for some reason, they are not parsed.
|
Contributor
Author
|
@danielchodusov can you create issue instead please? |
This was referenced May 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For details about this see https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda
Here's one idea/use case which could utilize this feature (not implemented in this PR as it requires more work)
I checked this in cmd.exe as well and no sideffects there