Bump phpunit XSD version to 5.2 #29175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some attributes being used in the phpunit configuration files, namely failOnRisky and failOnWarning were introduced in phpunit 5.2.0. The Composer configuration shows that tests should run with old versions of phpunit, but phpunit only validates the configuration against the XSD since phpunit 7.2.0. These changes can be tested as follows: wget http://schema.phpunit.de/5.2/phpunit.xsd xargs xmllint --schema phpunit.xsd 1>/dev/null find src -name phpunit.xml.dist| xargs xmllint --schema phpunit.xsd 1>/dev/null See sebastianbergmann/phpunit@7e06a82 See https://github.com/symfony/symfony/blob/46e3745a03e199e64cc0fcf3284a96b5a25dcee9/composer.json#L98
17e0bfa to
4dce4b7
Compare
nicolas-grekas
approved these changes
Nov 11, 2018
xabbuh
approved these changes
Nov 11, 2018
|
The Travis failure seems unrelated, and from the output, it looks like someone used |
OskarStark
approved these changes
Nov 11, 2018
|
I confirm about the failure: it's related but not an issue with the patch itself. Good to merge. |
|
Thank you @greg0ire. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 11, 2018
This PR was merged into the 2.8 branch. Discussion ---------- Bump phpunit XSD version to 5.2 | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Some attributes being used in the phpunit configuration files, namely `failOnRisky` and `failOnWarning` were introduced in phpunit 5.2.0. The Composer configuration shows that tests should run with old versions of phpunit, but phpunit only validates the configuration against the XSD since phpunit 7.2.0 These changes can be tested as follows: ``` wget http://schema.phpunit.de/5.2/phpunit.xsd xargs xmllint --schema phpunit.xsd 1>/dev/null find src -name phpunit.xml.dist| xargs xmllint --schema phpunit.xsd 1>/dev/null ``` See sebastianbergmann/phpunit@7e06a82 See https://github.com/symfony/symfony/blob/46e3745a03e199e64cc0fcf3284a96b5a25dcee9/composer.json#L98 Commits ------- 4dce4b7 Bump phpunit XSD version to 5.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some attributes being used in the phpunit configuration files, namely
failOnRiskyandfailOnWarningwere introduced in phpunit 5.2.0. TheComposer configuration shows that tests should run with old versions of
phpunit, but phpunit only validates the configuration against the XSD
since phpunit 7.2.0
These changes can be tested as follows:
See sebastianbergmann/phpunit@7e06a82
See
symfony/composer.json
Line 98 in 46e3745