[Form] Hardened test suite for empty data #29179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f2ae2d to
6430cf0
Compare
6430cf0 to
b0dab62
Compare
xabbuh
reviewed
Nov 11, 2018
| $form->submit(null); | ||
|
|
||
| // view data is transformed to the string true value | ||
| $this->assertSame('1', $form->getViewData()); |
There was a problem hiding this comment.
This test is a bit confusing, why do we receive 1 here when the empty_data is set to empty?
There was a problem hiding this comment.
We can define any true value as empty data as long as the view transformer supports it as input of reverseTransform. In any case it will transform back the norm data to view data, so we end up with '1' which is the default output of transform.
The same happens for any type using a transformer (almost all those overriding the base one).
If we actually define entries in empty data arrays of date types or RepeatedType we get the exact same result due to the transformation process.
xabbuh
approved these changes
Nov 11, 2018
|
Thank you @HeahDude. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 11, 2018
This PR was merged into the 2.8 branch. Discussion ---------- [Form] Hardened test suite for empty data | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | # | License | MIT | Doc PR | ~ Finally the continuation of #21877, giving some more love to 2.8 before it is not maintained anymore <3. Commits ------- b0dab62 [Form] Hardened test suite for empty data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally the continuation of #21877, giving some more love to 2.8 before it is not maintained anymore <3.