Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BUG-Fix] issue#29187 Duplication of form_errors field #29188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jawadmjn
Copy link

Q A
Bug fix? yes
New feature? no
Deprecations? yes/no
Tests pass? yes
Fixed tickets #29187
License MIT

Releated to issue

@ro0NL
Copy link
Contributor

ro0NL commented Nov 12, 2018

Im not sure it's the right fix, as you basically revert #24435 now

@xabbuh
Copy link
Member

xabbuh commented Nov 13, 2018

In #29207 I propose a slightly different way to fix this issue.

@jawadmjn
Copy link
Author

@ro0NL Actually it is not a revert of #24435, Because in #24435 happening so many other things also.

I just fix the thing what I need as per describe in the issue 29187

Because in the end, we do not want to destroy our layout when errors are appearing in formField.

@xabbuh
Copy link
Member

xabbuh commented Dec 12, 2018

Thank you for your work on this. But the right "fix" to clarify the behaviour in the documentation.

@xabbuh xabbuh closed this Dec 12, 2018
@jawadmjn
Copy link
Author

@nicolas-grekas @xabbuh Hi and thanks for the feedback, but I really did not get it that how can we go with a solution when our LayOut is broken? As mentioned Here

@xabbuh
Copy link
Member

xabbuh commented Dec 14, 2018

@jawadmjn You can still overwrite the form_label block to customise how and when errors are rendered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants