[Debug][HttpKernel] remove frames added by DebugClassLoader in stack traces #29190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 12, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28818 |
| License | MIT |
| Doc PR | - |
stof
reviewed
Nov 12, 2018
2e7eaf6 to
76e7944
Compare
j4nr6n
approved these changes
Nov 15, 2018
|
@j4nr6n the example you used is not affected by this change. This is about the deprecations coming from the DebugClassLoader which is not triggered in your example. |
fabpot
approved these changes
Nov 16, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 16, 2018
…r in stack traces (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Debug][HttpKernel] remove frames added by DebugClassLoader in stack traces | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28818 | License | MIT | Doc PR | -  Commits ------- 76e7944 [Debug][HttpKernel] remove frames added by DebugClassLoader in stack traces
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.