[Translation] make intl+icu format seamless by handling it in MessageCatalogue #29220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 14, 2018
•
| Q | A |
|---|---|
| Branch? | 4.2 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #29136 |
| License | MIT |
| Doc PR | - |
gharlan
approved these changes
Nov 14, 2018
There was a problem hiding this comment.
It fixes my issue (tested profiler and command debug:translation)
Thanks @nicolas-grekas!
stof
approved these changes
Nov 14, 2018
b3446d2 to
4b05ff6
Compare
|
Now with tests. PR ready. |
|
@nicolas-grekas wouldn't |
|
It could, but that'd mean make a new feature accessible via a deprecated API. I'd prefer not allowing it. OK for you? |
|
OH, GOT IT. |
|
GRR. OK, fixed. Good catch @stof :) |
4b05ff6 to
c71dfb9
Compare
stof
approved these changes
Nov 14, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Nov 15, 2018
… in MessageCatalogue (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Translation] make intl+icu format seamless by handling it in MessageCatalogue | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29136 | License | MIT | Doc PR | - Commits ------- c71dfb9 [Translation] make intl+icu format seamless by handling it in MessageCatalogue
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.