[SecurityBundle] Fix remember-me cookie framework inheritance when session is disabled #29224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does anyone know how to get the tests green without having to setup a kernel? |
|
(tests are red) |
I know, but I don't know (yet) how to get green test suite. I'm still looking at the differences between 7.1 and 7.2 deps=low to find how to get green tests. |
cd src/Symfony/Bundle/SecurityBundle
composer up --prefer-lowest --prefer-stable
../../../../phpunit |
chalasr
reviewed
Nov 14, 2018
src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/SecurityExtensionTest.php
Show resolved
Hide resolved
…ssion is disabled
|
AppVeyor build failure seems unrelated. |
nicolas-grekas
approved these changes
Nov 14, 2018
xabbuh
approved these changes
Nov 15, 2018
chalasr
approved these changes
Nov 15, 2018
|
Thank you @fbourigault. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 15, 2018
…nce when session is disabled (fbourigault) This PR was merged into the 4.2-dev branch. Discussion ---------- [SecurityBundle] Fix remember-me cookie framework inheritance when session is disabled | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29217 | License | MIT | Doc PR | N/A When `framework.session` configuration key is not an array, we ignore it. Commits ------- af81008 [SecurityBundle] Fix remember-me cookie framework inheritance when session is disabled
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
framework.sessionconfiguration key is not an array, we ignore it.