[Lock] Fixed PdoStore::putOffExpiration(), PdoStore::getHashedKey() #29260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But we don't enable strict types, so this change is not necessary! |
|
@nicolas-grekas ok, but what about PdoStore::putOffExpiration() fix? |
|
I don't get them. Can't we reference the same parameter twice? Can you give a few more hints please? |
|
Yes, according to http://php.net/pdo.prepare
|
nicolas-grekas
approved these changes
Nov 24, 2018
78ab196 to
a639301
Compare
|
Thank you @PavelPrischepa. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 24, 2018
…shedKey() (PavelPrischepa) This PR was merged into the 4.2-dev branch. Discussion ---------- [Lock] Fixed PdoStore::putOffExpiration(), PdoStore::getHashedKey() | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | It seems no | Fixed tickets | | License | MIT | Doc PR | 1. Fixed PDO Statement exception in PdoStore::putOffExpiration(): ``` An exception occurred while executing 'UPDATE lock_keys SET key_expiration = UNIX_TIMESTAMP() + 10, key_token = :token WHERE key_id = :id AND (key_token = :token OR key_expiration <= UNIX_TIMESTAMP())' with params ["dcfc5ff369bc1896563 325c2e90478154eb670f6b6ebad3617e946ecb1f81517", "FRJOnftxRwPIgIRVb4EpOIVFwNjTmx0fwkBSTVJdViI="]: SQLSTATE[HY093]: Invalid parameter number ``` 2. Added explicit casting `Key` to `string` in getHashedKey() to avoid error with `strict_types` enabled. Commits ------- a639301 [Lock] Fixed PDOStatement exception "Invalid parameter number" in putOffExpiration()
samnela
pushed a commit
to samnela/symfony
that referenced
this pull request
Nov 25, 2018
…::getHashedKey() (PavelPrischepa) This PR was merged into the 4.2-dev branch. Discussion ---------- [Lock] Fixed PdoStore::putOffExpiration(), PdoStore::getHashedKey() | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | It seems no | Fixed tickets | | License | MIT | Doc PR | 1. Fixed PDO Statement exception in PdoStore::putOffExpiration(): ``` An exception occurred while executing 'UPDATE lock_keys SET key_expiration = UNIX_TIMESTAMP() + 10, key_token = :token WHERE key_id = :id AND (key_token = :token OR key_expiration <= UNIX_TIMESTAMP())' with params ["dcfc5ff369bc1896563 325c2e90478154eb670f6b6ebad3617e946ecb1f81517", "FRJOnftxRwPIgIRVb4EpOIVFwNjTmx0fwkBSTVJdViI="]: SQLSTATE[HY093]: Invalid parameter number ``` 2. Added explicit casting `Key` to `string` in getHashedKey() to avoid error with `strict_types` enabled. Commits ------- a639301 [Lock] Fixed PDOStatement exception "Invalid parameter number" in putOffExpiration()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keytostringin getHashedKey() to avoid error withstrict_typesenabled.