FileLocator service definition update: look for templates in /templates directory instead of deprecated /src/Resources #29262
Conversation
domnuprofesor
commented
Nov 19, 2018
| Q | A |
|---|---|
| Branch? | master for features / 2.8 up to 4.1 for bug fixes |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
…es directory instead of deprecated /src/Resources
|
@yceruto maybe for review? |
|
I don't have much information. @domnuprofesor could you explain what's the issue are you faced? |
|
Maybe related to #25811 (comment) |
| @@ -48,7 +48,7 @@ | |||
|
|
|||
| <service id="file_locator" class="Symfony\Component\HttpKernel\Config\FileLocator"> | |||
| <argument type="service" id="kernel" /> | |||
| <argument>%kernel.root_dir%/Resources</argument> | |||
| <argument>%kernel.root_dir%/../templates</argument> | |||
There was a problem hiding this comment.
The fact it is %kernel.root_dir%/Resources and not %kernel.root_dir%/Resources/views hints that FileLocator is not only about locating templates but any resource (see class and interface description), replacing this path by templates does not look right to me.
Also making FileLocator suddenly stop being able to locate resources from the deprecated path is not good regarding BC, using it for such resources should trigger a deprecation notice first.
We could also need to deprecate this argument at the class level before 5.0 since there is no global Resources directory anymore (directories previously stored in the app/Resources folder are now first-level dirs like /templates and /translations), and kernel.root_dir won't exist anymore in 5.0.
|
Closing as per @chalasr's comment. |