[EventDispatcher] Split events across requests#29312
Merged
fabpot merged 1 commit intosymfony:masterfrom Apr 2, 2019
ro0NL:split-event
Merged
[EventDispatcher] Split events across requests#29312fabpot merged 1 commit intosymfony:masterfrom ro0NL:split-event
fabpot merged 1 commit intosymfony:masterfrom
ro0NL:split-event
Conversation
ro0NL
commented
Nov 25, 2018
src/Symfony/Component/EventDispatcher/Debug/TraceableEventDispatcher.php
Show resolved
Hide resolved
src/Symfony/Component/EventDispatcher/Debug/TraceableEventDispatcher.php
Show resolved
Hide resolved
| } | ||
|
|
||
| $this->called[$eventName]->attach($listener); | ||
| $this->callStack->attach($listener, array($eventName, $this->currentRequestHash)); |
Contributor
Author
There was a problem hiding this comment.
same issue with keys; grouping by event name breaks the dispatch order
src/Symfony/Component/EventDispatcher/Debug/TraceableEventDispatcher.php
Show resolved
Hide resolved
Contributor
Author
|
Last but not least, i think we should append each wrapped listener to the call stack during pre process and lazy verify if it was called yes/no. Currently it's added to the call stack during post-process which affects the order. I.e. the main kernel.exception is called before the sub kernel.reques, but we only collect that after the sub request finished. |
Contributor
Author
|
Ive updated above screenshots after c737944 |
This was referenced Nov 30, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Dec 1, 2018
This PR was merged into the 4.1 branch. Discussion ---------- [WebProfilerBundle] Fix title case | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Split from #29312 for 4.1 👼 Commits ------- 3e16e25 [WebProfilerBundle] Fix title case
nicolas-grekas
added a commit
that referenced
this pull request
Dec 17, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [EventDispatcher] Revers event tracing order | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Split from #29312 for 3.4 This traces events in dispatch order. Before:  After:  Here we see it also collects "terminate" events (both kernel & console for not-called listeners). In case of exception page the fix is even better: #29312 (review) Which now correctly shows the kernel.exception event of the main request is dispatched _before_ the kernel.request event of the sub-request. Moreover, it de-duplicates events. So we actually see the sub-request events 🎉 _Havent looked at tests yet._ Commits ------- 2570d6f [EventDispatcher] Revers event tracing order
symfony-splitter
pushed a commit
to symfony/event-dispatcher
that referenced
this pull request
Dec 17, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [EventDispatcher] Revers event tracing order | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Split from #29312 for 3.4 This traces events in dispatch order. Before:  After:  Here we see it also collects "terminate" events (both kernel & console for not-called listeners). In case of exception page the fix is even better: symfony/symfony#29312 (review) Which now correctly shows the kernel.exception event of the main request is dispatched _before_ the kernel.request event of the sub-request. Moreover, it de-duplicates events. So we actually see the sub-request events 🎉 _Havent looked at tests yet._ Commits ------- 2570d6f877 [EventDispatcher] Revers event tracing order
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
What about making the class @final? (if you agree, don't forget updating the changelog file)
- rebase needed btw
src/Symfony/Component/EventDispatcher/Debug/TraceableEventDispatcher.php
Show resolved
Hide resolved
Member
|
@ro0NL Do you think you can finish this one for 4.3? |
Contributor
Author
|
@fabpot done. |
Member
|
@ro0NL Apparently, tests do not pass. Can you have a look please? |
Contributor
Author
|
Let's see now :) i think it's a shortcoming of sf/debug not accounting for |
Member
It's not a bug it's a feature. You must have to change your code when a lower layer decides to deprecate something. This is how. |
fabpot
approved these changes
Apr 2, 2019
Member
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Apr 2, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #29312). Discussion ---------- [EventDispatcher] Split events across requests | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #24275 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Split events per request, as currently a profiled sub-request includes all events. Follows same approach how logs are split in #23659. Commits ------- c3477ba [EventDispatcher] Split events across requests
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split events per request, as currently a profiled sub-request includes all events. Follows same approach how logs are split in #23659.