Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Console] Move back root exception to stack trace in verbose mode #29318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2018
Merged

[Console] Move back root exception to stack trace in verbose mode #29318

merged 1 commit into from
Nov 26, 2018

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Nov 25, 2018 •
edited
Loading

Q A
Branch? 3.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29232
License MIT
Doc PR n/a

@chalasr chalasr added this to the next milestone Nov 25, 2018
@chalasr chalasr force-pushed the cli-full-trace-in-vv-mode branch 2 times, most recently from 53afcc0 to fbe2bf8 Compare November 25, 2018 16:04
@chalasr chalasr mentioned this pull request Nov 25, 2018
Closed
@chalasr
Copy link
Member Author

chalasr commented Nov 25, 2018 •
edited
Loading

3.4 totally misses the root exception when it's a built-in console ExceptionInterface instance, no matter the verbosity (#24131). Should we consider it a bug?

edit: I think so, rebased on 3.4

@chalasr chalasr changed the base branch from master to 3.4 November 25, 2018 21:05
@chalasr chalasr force-pushed the cli-full-trace-in-vv-mode branch 2 times, most recently from e71a41d to 3545321 Compare November 25, 2018 21:06
@chalasr chalasr modified the milestones: next, 3.4 Nov 25, 2018
@chalasr chalasr force-pushed the cli-full-trace-in-vv-mode branch from 3545321 to c3f4c3a Compare November 25, 2018 21:20
@chalasr chalasr force-pushed the cli-full-trace-in-vv-mode branch from c3f4c3a to 63cd219 Compare November 26, 2018 12:48
@fabpot
Copy link
Member

fabpot commented Nov 26, 2018

Thank you @chalasr.

@fabpot fabpot merged commit 63cd219 into symfony:3.4 Nov 26, 2018
fabpot added a commit that referenced this pull request Nov 26, 2018
@fabpot
bug #29318 [Console] Move back root exception to stack trace in verbo…
d6bbde5 
…se mode (chalasr)

This PR was merged into the 3.4 branch.

Discussion
----------

[Console] Move back root exception to stack trace in verbose mode

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29232
| License       | MIT
| Doc PR        | n/a

Commits
-------

63cd219 [Console] Move back root exception to stack trace in verbose mode
@fabpot fabpot mentioned this pull request Nov 26, 2018
Merged
@chalasr chalasr deleted the cli-full-trace-in-vv-mode branch November 26, 2018 14:08
This was referenced Nov 26, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@lyrixx lyrixx lyrixx approved these changes

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Bug Console Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@chalasr @fabpot @lyrixx @carsonbot