[PropertyAccess] Extract AccessInfoGuesser from PropertyAccessor #29342
Conversation
|
This is something that i also proposed in #26613 IMO This should be in the property info component (but would add a dependcy here) |
| use Symfony\Component\Cache\Adapter\NullAdapter; | ||
| use Symfony\Component\Inflector\Inflector; | ||
|
|
||
| final class AccessInfoGuesser |
There was a problem hiding this comment.
Should have an associated interface if marked final. And I agree that it would fit in PropertyInfo.
There was a problem hiding this comment.
I'm not enthusiast about moving this code to PropertyInfo because return value of getReadAccessInfo is really hard to use. You have many cases to handle to get things working the right way. Moreover, it would be hard to apply BC promise on such return type.
| * | ||
| * @return array | ||
| */ | ||
| public function getReadAccessInfo($class, $property) |
There was a problem hiding this comment.
| public function getReadAccessInfo($class, $property) | |
| public function getReadAccessInfo(string $class, string $property): array |
Typehint can be added everywhere because it's a new class.
|
I'm closing this one as #29405 is the way I want to go to improve |
This is an attempt to extract
PropertyAccessor::getReadAccessInfoandPropertyAccessor::getWriteAccessInfoin a dedicated class.This would allow:
PropertyAccessorwhich will be faster than PSR-6 caching.WDYT?