[Workflow] Move code from ValidateWorkflowsPass to the FrameworkExtension #29457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
previously requested changes
Dec 4, 2018
src/Symfony/Component/Workflow/DependencyInjection/ValidateWorkflowsPass.php
Outdated
Show resolved
Hide resolved
378c4f9 to
7c4afd4
Compare
|
The compiler pass should be deprecated, not removed. It don't think making such BC break is actually worth it compared to the deprecation path. |
|
Okay, Il will deprecate it. |
7c4afd4 to
5261743
Compare
|
Hi. I rebased and finished this PR. I put back the ValidateWorkflowsPass but I deprecate it. |
5261743 to
a608797
Compare
lyrixx
added a commit
that referenced
this pull request
Mar 13, 2019
…rameworkExtension (lyrixx) This PR was merged into the 4.3-dev branch. Discussion ---------- [Workflow] Move code from ValidateWorkflowsPass to the FrameworkExtension | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | --- Just some cleaning. See #29146 (comment) Commits ------- a608797 [Workflow] Move code from ValidateWorkflowsPass to the FrameworkExtension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some cleaning. See
#29146 (comment)