[Hackday][Messenger] Add an alias for transport.symfony_serializer so SerializerInterface can be autowired#29517
Merged
nicolas-grekas merged 1 commit intosymfony:masterfrom Dec 13, 2018
Conversation
Member
|
#SymfonyConHackday2018 |
chalasr
requested changes
Dec 8, 2018
src/Symfony/Bundle/FrameworkBundle/Resources/config/messenger.xml
Outdated
Show resolved
Hide resolved
chalasr
approved these changes
Dec 8, 2018
Member
chalasr
left a comment
There was a problem hiding this comment.
👍 with minor comment.
Sounds more like a feature to me, better merge it on master I'd say.
src/Symfony/Bundle/FrameworkBundle/Resources/config/messenger.xml
Outdated
Show resolved
Hide resolved
Contributor
|
I wondered about this alias before, but the serializer is configurable through the |
Member
|
Status: needs work |
chalasr
approved these changes
Dec 9, 2018
ogizanagi
approved these changes
Dec 9, 2018
Member
|
I think we prefer defining in xml and removing in the extension: that makes the xml more useful to eg IDE plugins that want to use it. |
Contributor
Author
|
@nicolas-grekas Did you mean this? please review |
nicolas-grekas
approved these changes
Dec 10, 2018
src/Symfony/Bundle/FrameworkBundle/Resources/config/messenger.xml
Outdated
Show resolved
Hide resolved
… SerializerInterface can be autowired
218ba84 to
2f0e948
Compare
Member
|
Thank you @karser. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 13, 2018
…y_serializer so SerializerInterface can be autowired (karser) This PR was submitted for the 4.2 branch but it was squashed and merged into the 4.3-dev branch instead (closes #29517). Discussion ---------- [Hackday][Messenger] Add an alias for transport.symfony_serializer so SerializerInterface can be autowired | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | License | MIT cc @thePanz Use case: Before: ``` Pnz\Messenger\FilesystemTransport\FilesystemTransportFactory: arguments: - '@messenger.transport.symfony_serializer' tags: ['messenger.transport_factory'] ``` After: ``` Pnz\Messenger\FilesystemTransport\FilesystemTransportFactory: tags: ['messenger.transport_factory'] ``` Commits ------- 2f0e948 [Hackday][Messenger] Add an alias for transport.symfony_serializer so SerializerInterface can be autowired
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @thePanz
Use case:
Before:
After: