Added support for serializedName alias in properties. Fixed #15171 #29615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acataluddi
commented
Dec 14, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #15171 |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
| @@ -109,19 +109,24 @@ public function normalize($object, $format = null, array $context = array()) | |||
| $attributeValue = $maxDepthHandler($attributeValue, $object, $attribute, $format, $context); | |||
| } | |||
|
|
|||
| // Adding support for serialized-name | |||
| array_key_exists($attribute, $attributesMetadata) && null !== $attributesMetadata[$attribute]->getSerializedName() ? | |||
There was a problem hiding this comment.
I don't know if this syntax work, it's not documented: http://us2.php.net/manual/en/language.operators.comparison.php#language.operators.comparison.ternary
Anyway, IMHO it will be easier to read if written as:
Suggested change
| array_key_exists($attribute, $attributesMetadata) && null !== $attributesMetadata[$attribute]->getSerializedName() ? | |
| $serializedName = (array_key_exists($attribute, $attributesMetadata) && null !== $attributesMetadata[$attribute]->getSerializedName()) ? | |
| $attributesMetadata[$attribute]->getSerializedName() : | |
| $attribute; |
(and it can be expanded in multiple lines to avoid one long line with 2 expressions)
There was a problem hiding this comment.
Hi Alexis,
Yes, looks a sensible suggestion. However, even though the implementation is working, it breaks some unit test. I think I need to understand more about the Normaliser before actually pull it again.
Thanks,
Adriano
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.