[VarDumper] Add descriptors tests #29642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Dec 19, 2018
OskarStark
approved these changes
Dec 19, 2018
fabpot
approved these changes
Dec 23, 2018
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Dec 23, 2018
This PR was merged into the 4.1 branch. Discussion ---------- [VarDumper] Add descriptors tests | Q | A | ------------- | --- | Branch? | 4.1 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Just adding some tests for these classes & fixing a small issue with the optional `project_dir` entry from `source` context provider. If merged before #29613, I'll update tests in it (796ca6b) (otherwise could be picked on merge). Commits ------- 8570b8a [VarDumper] Add descriptors tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding some tests for these classes & fixing a small issue with the optional
project_direntry fromsourcecontext provider.If merged before #29613, I'll update tests in it (796ca6b) (otherwise could be picked on merge).